feat(prefer-wait-for): remove rule (#648)

BREAKING CHANGE: `prefer-wait-for` is now removed
testing-library · Oct 4, 2022 · 20f23ad · 20f23ad
1 parent 6de1d96
commit 20f23ad
Show file tree

Hide file tree

Showing 6 changed files with 2 additions and 2,549 deletions.
diff --git a/.github/ISSUE_TEMPLATE/propose_new_rule.yml b/.github/ISSUE_TEMPLATE/propose_new_rule.yml
@@ -7,7 +7,7 @@ body:
     attributes:
       label: Name for new rule
       description: Suggest a name for the new rule that follows the [rule naming conventions](https://github.com/testing-library/eslint-plugin-testing-library/blob/main/CONTRIBUTING.md#rule-naming-conventions).
-      placeholder: prefer-wait-for
+      placeholder: prefer-find-by
     validations:
       required: true
 

diff --git a/README.md b/README.md
@@ -231,7 +231,6 @@ To enable this configuration use the `extends` property in your
 | [`prefer-query-by-disappearance`](./docs/rules/prefer-query-by-disappearance.md)     | Suggest using `queryBy*` queries when waiting for disappearance                              |     | ![dom-badge][] ![angular-badge][] ![react-badge][] ![vue-badge][] ![marko-badge][] |
 | [`prefer-screen-queries`](./docs/rules/prefer-screen-queries.md)                     | Suggest using `screen` while querying                                                        |     | ![dom-badge][] ![angular-badge][] ![react-badge][] ![vue-badge][] ![marko-badge][] |
 | [`prefer-user-event`](./docs/rules/prefer-user-event.md)                             | Suggest using `userEvent` over `fireEvent` for simulating user interactions                  |     |                                                                                    |
-| [`prefer-wait-for`](./docs/rules/prefer-wait-for.md)                                 | Use `waitFor` instead of deprecated wait methods                                             | 🔧  |                                                                                    |
 | [`render-result-naming-convention`](./docs/rules/render-result-naming-convention.md) | Enforce a valid naming for return value from `render`                                        |     | ![angular-badge][] ![react-badge][] ![vue-badge][] ![marko-badge][]                |
 
 <!-- RULES-LIST:END -->

diff --git a/docs/rules/prefer-wait-for.md b/docs/rules/prefer-wait-for.md
diff --git a/lib/rules/prefer-wait-for.ts b/lib/rules/prefer-wait-for.ts
diff --git a/tests/index.test.ts b/tests/index.test.ts
@@ -8,7 +8,7 @@ import plugin from '../lib';
 const execAsync = util.promisify(exec);
 const generateConfigs = () => execAsync(`npm run generate:configs`);
 
-const numberOfRules = 27;
+const numberOfRules = 26;
 const ruleNames = Object.keys(plugin.rules);
 
 // eslint-disable-next-line jest/expect-expect