fix(prefer-user-event): prevent crash with custom createEvent function (

#422) (#422) Closes #405 Co-authored-by: Mario Beltrán Alarcón <belco90@gmail.com>
testing-library · Jul 20, 2021 · 4808bca · 4808bca
1 parent 5dff88e
commit 4808bca
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/lib/rules/prefer-user-event.ts b/lib/rules/prefer-user-event.ts
@@ -182,7 +182,7 @@ export default createTestingLibraryRule<Options, MessageIds>({
           ASTUtils.isIdentifier(node.init.callee.property)
         ) {
           fireEventMethodName = node.init.callee.property.name;
-        } else {
+        } else if (node.init.arguments.length > 0) {
           fireEventMethodName = (node.init.arguments[0] as TSESTree.Literal)
             .value as string;
         }

diff --git a/tests/lib/rules/prefer-user-event.test.ts b/tests/lib/rules/prefer-user-event.test.ts
@@ -265,6 +265,12 @@ ruleTester.run(RULE_NAME, rule, {
         fireEventAliased(node, event)
       `,
     },
+    {
+      code: `
+        const createEvent = () => 'Event';
+        const event = createEvent();
+      `,
+    },
   ],
   invalid: [
     ...createScenarioWithImport<TSESLint.InvalidTestCase<MessageIds, Options>>(