fix(no-global-regexp-flag-in-query): check if empty name property node (

#566) * fix(no-global-regexp-flag-in-query): check if empty name property node * style: write the valid snippet without an object Closes #565
testing-library · Apr 4, 2022 · 7f751e1 · 7f751e1
1 parent b62ba43
commit 7f751e1
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/lib/rules/no-global-regexp-flag-in-query.ts b/lib/rules/no-global-regexp-flag-in-query.ts
@@ -96,8 +96,11 @@ export default createTestingLibraryRule<Options, MessageIds>({
               ASTUtils.isIdentifier(p.key) &&
               p.key.name === 'name' &&
               isLiteral(p.value)
-          ) as TSESTree.ObjectLiteralElement & { value: TSESTree.Literal };
-          report(namePropertyNode.value);
+          ) as TSESTree.Property | undefined;
+
+          if (namePropertyNode) {
+            report(namePropertyNode.value);
+          }
         }
       },
     };

diff --git a/tests/lib/rules/no-global-regexp-flag-in-query.test.ts b/tests/lib/rules/no-global-regexp-flag-in-query.test.ts
@@ -78,6 +78,17 @@ ruleTester.run(RULE_NAME, rule, {
         const utils = render(<Component/>)
         utils.notAQuery(/hello/i)
     `,
+
+    // issue #565
+    `
+      import { screen } from "@testing-library/react"
+
+      describe("App", () => {
+        test("is rendered", async () => {
+          await screen.findByText("Hello World", { exact: false });
+        })
+      })
+    `,
   ],
   invalid: [
     {