feat(no-wait-for-side-effects): report render in waitFor

[zaicevas]

Closes #360

We should decide how we want to release this enhancement. Seems like the discussion is centered around:
a) minor version bump without an option
b) minor version bump with an option, which is off by default

Also, I've noticed this rule is NOT reporting this case. Is that intentional? 🤔

    await waitFor(() => {
      userEvent.click(button) // reported
      const a = userEvent.click(button) // NOT reported
    })

[MichaelDeBoey]

Some small improvements to make the code a bit more readable, but otherwise LGTM! 👊

[Belco90]

Also, I've noticed this rule is NOT reporting this case. Is that intentional? 🤔

    await waitFor(() => {

      userEvent.click(button) // reported

      const a = userEvent.click(button) // NOT reported

    })

Good catch. It's not intentional, but I detected it when implementing no-unnecessary-act, so it will be addressed there. I'll make sure to include this case in the tests.

[Belco90]

@zaicevas Thanks for your PR, it looks great! Just some small tweaks about helpers receiving null nodes and I think it's ready to go.

[Belco90]

Pretty happy with the implementation and its tests! Last requirement: could you mention render will be reported in the rule docs, and include it in some invalid example?

[zaicevas]

Pretty happy with the implementation and its tests! Last requirement: could you mention render will be reported in the rule docs, and include it in some invalid example?

Done :) Not sure which link to add in Further Reading, tho (if any)

[MichaelDeBoey]

Just one small thing and than this one can be merged for me

[MichaelDeBoey]

LGTM! 👊

[Belco90]

No more further reading links are needed, with existing ones + rule description is more than enough.

Releasing this as a minor then. We haven't set the final SemVer Policy but this sort of extra error reported would be expected at the Feature release level.

I finally won't adapt this implementation with the new function I added to no-unnecessary-act since my PR is gonna have tons of changes, but I'll note it to do it in a separate PR (or even you can do it if you feel so!)

Thank you very much for your work here @zaicevas!

[github-actions]

🎉 This PR is included in version 4.2.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀