Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(await-async-events): avoid reporting userEvent.setup() in wrappers #834

Merged
merged 2 commits into from
Nov 9, 2023

Conversation

doochik
Copy link
Contributor

@doochik doochik commented Oct 24, 2023

Checks

Changes

Skipping all CallExpressions with nodes named "setup" in the await-async-events rule

Context

Better fix for #800 after #817

@Belco90 Belco90 changed the title fix(await-async-events): sync userEvent.setup() should not be reported fix(await-async-events): avoid reporting userEvent.setup() in wrappers Nov 9, 2023
Copy link
Member

@Belco90 Belco90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@Belco90 Belco90 merged commit a1bb21e into testing-library:main Nov 9, 2023
29 checks passed
@Belco90
Copy link
Member

Belco90 commented Nov 9, 2023

@all-contributors please add @doochik for code and test.

Copy link
Contributor

@Belco90

I've put up a pull request to add @doochik! 🎉

Copy link

github-actions bot commented Nov 9, 2023

🎉 This PR is included in version 6.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

await-async-events reports a problem when userEvent.setup is called from another function
2 participants