-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle multiple imports with no-manual-cleanup
#835
Conversation
e6ce349
to
774797d
Compare
👋 Curious if I can get some eyes this, cc @Belco90 |
I'll try to review this next week. |
Hi hi – bumping this again! Should be a very quick review. The PR just accounts for when someone might have multiple testing library imports (which is common in my company's codebase). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for taking care of this!
🎉 This PR is included in version 6.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@all-contributors please add @maisano for code and test |
I've put up a pull request to add @maisano! 🎉 |
Checks
Changes
Crawl all the import references when sniffing out
no-manual-cleanup
violations.Context
There is currently a bug with
no-manual-cleanup
where we only ever check the first import of anytesting-library
package. While duplicative imports of the same package is very likely uncommon, there are many packages within thetesting-library
ecosystem that will trip up the package detection and break this rule when we only look at the first.