Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop support for old Node.js versions #898

Merged
merged 6 commits into from
Apr 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ on:
merge_group:

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
group: '${{ github.workflow }}-${{ github.ref }}'
cancel-in-progress: true

jobs:
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/verifications.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,7 @@ jobs:
strategy:
fail-fast: false
matrix:
# The .x indicates "the most recent one"
node: [19.x, 18.x, 17.x, 16.x, 14.x, 14.17.0, 12.x, 12.22.0]
node: [18.18, 20.9, 21.1]
eslint: [7.5, 7, 8]
steps:
- name: Checkout
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
16
20.12
15 changes: 8 additions & 7 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,19 +22,19 @@
[![PRs Welcome][pr-badge]][pr-url]
[![All Contributors][all-contributors-badge]](#contributors-)

## Installation
## Prerequisites

You'll first need to install [ESLint](https://eslint.org):
To use this plugin, you must have [Node.js](https://nodejs.org/en/) (`^18.18.0`, `^20.9.0`, or `>=21.1.0`) installed.

```shell
$ npm install --save-dev eslint
# or
$ yarn add --dev eslint
```
## Installation

You'll first need to [install ESLint](https://eslint.org/docs/latest/use/getting-started).

Next, install `eslint-plugin-testing-library`:

```shell
$ pnpm add --save-dev eslint-plugin-testing-library
# or
$ npm install --save-dev eslint-plugin-testing-library
# or
$ yarn add --dev eslint-plugin-testing-library
Expand All @@ -49,6 +49,7 @@ You can find detailed guides for migrating `eslint-plugin-testing-library` in th
- [Migration guide for v4](docs/migration-guides/v4.md)
- [Migration guide for v5](docs/migration-guides/v5.md)
- [Migration guide for v6](docs/migration-guides/v6.md)
- [Migration guide for v7](docs/migration-guides/v7.md)

## Usage

Expand Down
11 changes: 11 additions & 0 deletions docs/migration-guides/v7.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# Guide: migrating to v7

If you are not on v6 yet, we recommend first following the [v6 migration guide](docs/migration-guides/v6.md).

## Overview

- _(Breaking)_ Supported versions of Node.js have been updated to `^18.18.0`, `^20.9.0`, or `>=21.1.0`, matching ESLint.

## Steps to upgrade

- Make sure you are using a supported version of Node.js
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@
"eslint": "^7.5.0 || ^8.0.0"
},
"engines": {
"node": "^12.22.0 || ^14.17.0 || >=16.0.0",
"node": "^18.18.0 || ^20.9.0 || >=21.1.0",
"npm": ">=6"
}
}