Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove Ramda dependency #97

Closed
mdjastrzebski opened this issue Aug 10, 2022 · 1 comment · Fixed by #98
Closed

refactor: remove Ramda dependency #97

mdjastrzebski opened this issue Aug 10, 2022 · 1 comment · Fixed by #98
Labels
enhancement New feature or request help wanted Extra attention is needed released

Comments

@mdjastrzebski
Copy link
Collaborator

Describe the feature you'd like:

Remove Ramda dependency and replace with plain JS method where possible. Ramda has affected performance of Jest tests due to badly implemented treeshaking, and attempt #82 to optimise it using custom imports have caused issues for some users.

Suggested implementation:

Replace Ramda methods like includes with their native modern JS counterparts.

Describe alternatives you've considered:

Use other utility library with better import performance, maybe Rambda (note "b" in the name)

Teachability, Documentation, Adoption, Migration Strategy:

This should be transparent to the users.

@mdjastrzebski mdjastrzebski added enhancement New feature or request help wanted Extra attention is needed labels Aug 10, 2022
@github-actions
Copy link

🎉 This issue has been resolved in version 4.0.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant