Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update ramda imports #82

Merged
merged 1 commit into from
Aug 9, 2022
Merged

Conversation

mdjastrzebski
Copy link
Collaborator

@mdjastrzebski mdjastrzebski commented Aug 9, 2022

What:

Importing Jest Native in projects based on Node 14+ results in following error:

    ENOENT: no such file or directory, open '/Users/maciej/Dev/react-native-testing-library/examples/basic/node_modules/ramda/src/compose'

      at Runtime.readFile (node_modules/jest-runtime/build/index.js:2574:21)
      at Object.<anonymous> (node_modules/@testing-library/jest-native/dist/to-be-disabled.js:9:39)

Why:

Under node 14 the .js file extensions seems necessary in case of Ramda. Probably due to some technicalities of how Ramda export these. Note that Ramda does not seem maintained lately.

How:

App '.js' file extension to Ramda imports

Checklist:

  • Documentation added to the
    docs
  • Typescript definitions updated
  • Tests
  • Ready to be merged

@mdjastrzebski mdjastrzebski added the bug Something isn't working label Aug 9, 2022
@codecov
Copy link

codecov bot commented Aug 9, 2022

Codecov Report

Merging #82 (3ecce3b) into main (8d0e79f) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #82   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          143       143           
  Branches        44        44           
=========================================
  Hits           143       143           
Flag Coverage Δ
node-12 100.00% <ø> (ø)
node-14 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/to-be-disabled.js 100.00% <ø> (ø)
src/to-be-empty.js 100.00% <ø> (ø)
src/to-contain-element.js 100.00% <ø> (ø)
src/to-have-prop.js 100.00% <ø> (ø)
src/to-have-style.js 100.00% <ø> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@mdjastrzebski mdjastrzebski merged commit 2904715 into main Aug 9, 2022
@mdjastrzebski mdjastrzebski deleted the fix/update-ramda-imports branch August 9, 2022 06:21
@github-actions
Copy link

github-actions bot commented Aug 9, 2022

🎉 This PR is included in version 4.0.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant