Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update @testing-library dependencies #49

Merged
merged 1 commit into from
May 18, 2022
Merged

chore: update @testing-library dependencies #49

merged 1 commit into from
May 18, 2022

Conversation

filipw01
Copy link
Contributor

BREAKING CHANGE: drops node 10 support

What:
Updated @testing-library/dom dependency and @testing-library/jest-dom dev dependency

Why:
Dependency requires some projects to have duplicate version of @testing-library/dom

How:
By updating package.json and updating engines entry

Checklist:

  • Documentation added N/A
  • Tests N/A
  • Typescript definitions updated N/A
  • Ready to be merged

BREAKING CHANGE: drops node 10 support
@orzechowskid
Copy link

I'd love to see this merged. being able to call
expect(screen.queryByRole('region', { description: 'my header text' }).not.toBeNull()
would be very nice in some of my unit tests, but the description property is not present in the Typescript definition files shipped with the version of @testing-library/dom currently used by @testing-library/preact.

@JoviDeCroock JoviDeCroock merged commit 4ccf063 into testing-library:master May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants