Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation missing on getByText matching strategy #96

Closed
EmilOJ opened this issue May 26, 2018 · 2 comments
Closed

Documentation missing on getByText matching strategy #96

EmilOJ opened this issue May 26, 2018 · 2 comments

Comments

@EmilOJ
Copy link

EmilOJ commented May 26, 2018 •
edited
Loading

It should be clear that getByText does not match when there are leading or trailing words in the text.
I spend two hours trying to debug why foo did not match foo bar.
I admit I got a mislead by a lot of react and relay stuff, but you should consider including a simple sentence about this :)

Love this library, btw
@johann-sonntagbauer
Copy link
Collaborator

@EmilOJ Have you seen the documentation for getByText in section textmatch?
https://github.com/kentcdodds/react-testing-library#textmatch

Please let us know how to make that point more clear :)
thx

@EmilOJ
Copy link
Author

EmilOJ commented May 26, 2018

I don't know why I didn't see this. No issue here! Thanks

@EmilOJ EmilOJ closed this as completed May 26, 2018
lucbpz pushed a commit to lucbpz/react-testing-library that referenced this issue Jul 26, 2020
@Gpx
fix: 🐛 don't fire events when clicking disabled checkbox
c20dce0 
disabled checkboxes don't fire any event

BREAKING CHANGE: 🧨 clicking disabled checkbox no longer fires events

✅ Closes: testing-library#96
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@johann-sonntagbauer @EmilOJ