Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure waitForElement responds to attribute and textNode changes… #137

Merged

Conversation

rbrtsmith
Copy link
Contributor

@rbrtsmith rbrtsmith commented Jul 17, 2018

  • Ensure waitForElement responds to attribute and textNode changes by default
  • Add rbrtsmith as a contributor

What:
Issue outlined in DOM Testing Library

Why:
Waiting for textNode and attribute changes is the desired default behaviour.

How:
Bump DOM Testing Library dependency

Checklist:

  • Documentation N/A
  • Tests N/A
  • Ready to be merged
  • Added myself to contributors table

… by default

* Ensure waitForElement responds to attribute and textNode changes by default
* Add rbrtsmith as a contributor
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super

@kentcdodds kentcdodds merged commit 1a11719 into testing-library:master Jul 17, 2018
@kentcdodds
Copy link
Member

🎉 This PR is included in version 4.1.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants