Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Trigger onPointerEnter/Leave when calling pointerEnter/Leave #784

Merged
merged 5 commits into from
Sep 13, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
20 changes: 20 additions & 0 deletions src/__tests__/events.js
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,26 @@ test('onChange works', () => {
expect(handleChange).toHaveBeenCalledTimes(1)
})

test('calling `onPointerEnter` directly works too', () => {
const handlePointerEnter = jest.fn()
const handlePointerLeave = jest.fn()
const {container} = render(
<div>
<button
onPointerEnter={handlePointerEnter}
onPointerLeave={handlePointerLeave}
/>
</div>,
)
const button = container.firstChild.firstChild

fireEvent.pointerEnter(button)
expect(handlePointerEnter).toHaveBeenCalledTimes(1)

fireEvent.pointerLeave(button)
expect(handlePointerLeave).toHaveBeenCalledTimes(1)
})

test('calling `fireEvent` directly works too', () => {
const handleEvent = jest.fn()
const {
Expand Down
11 changes: 11 additions & 0 deletions src/fire-event.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,17 @@ fireEvent.mouseLeave = (...args) => {
return fireEvent.mouseOut(...args)
}

const pointerEnter = fireEvent.pointerEnter
const pointerLeave = fireEvent.pointerLeave
fireEvent.pointerEnter = (...args) => {
pointerEnter(...args)
return fireEvent.pointerOver(...args)
}
fireEvent.pointerLeave = (...args) => {
pointerLeave(...args)
return fireEvent.pointerOut(...args)
}

const select = fireEvent.select
fireEvent.select = (node, init) => {
select(node, init)
Expand Down