Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): bump @testing-library/dom from 6.16.0 to 7.0.2 #78

Merged
merged 1 commit into from Mar 13, 2020

Conversation

dependabot-preview[bot]
Copy link
Contributor

Bumps @testing-library/dom from 6.16.0 to 7.0.2.

Release notes

Sourced from @testing-library/dom's releases.

v7.0.2

7.0.2 (2020-03-12)

Bug Fixes

  • remove very old deprecated method (98e5bb3)

v7.0.1

7.0.1 (2020-03-12)

Bug Fixes

  • find:* waitForElement was still in use (#476) (c0a4eb2)

v7.0.0

7.0.0 (2020-03-12)

Features

  • waitFor: replace wait with waitFor (read more in the Breaking changes list below) (2b641e1), closes #376 #416
  • waitForElementToBeRemoved: support passing an element directly (#460) (1b711a4)

The new feature in waitForElementToBeRemoved is pretty cool. Here's what you had to do before:

const submitButton = screen.getByText(/submit/i)
fireEvent.click(submitButton)
await waitForElementToBeRemoved(() => screen.getByText(/submit/i))
// submit is now gone

That still works, but you can now do this too:

const submitButton = screen.getByText(/submit/i)
fireEvent.click(submitButton)
await waitForElementToBeRemoved(submitButton)
// submit is now gone

Cool right!?

BREAKING CHANGES

Drop Node 8

Node 10 or greater is required. Node 8 is out of LTS (#459) (c3ab843), closes #430

... (truncated)
Commits
  • 98e5bb3 fix: remove very old deprecated method
  • c0a4eb2 fix(find*): waitForElement was still in use (#476)
  • 1b711a4 feat(waitForElementToBeRemoved): support passing an element directly (#460)
  • e3fdb8e feat: remove mutationobserver shim (#457)
  • 2b641e1 feat(waitFor): replace wait with waitFor
  • eea7e4d feat(ByLabelText): change selector to match target (not label) (#373)
  • c3ab843 fix: Drop Node 8 (#459)
  • bb4a1ed docs: add NMinhNguyen as a contributor (#466)
  • d88a1ba docs: add MichaelDeBoey as a contributor (#462)
  • d344a67 chore(ci): add beta to list of buildable branches
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot added the dependencies Pull requests that update a dependency file label Mar 13, 2020
@benmonro benmonro changed the title build(deps): bump @testing-library/dom from 6.16.0 to 7.0.2 fix(deps): bump @testing-library/dom from 6.16.0 to 7.0.2 Mar 13, 2020
@benmonro benmonro merged commit 402babe into master Mar 13, 2020
@benmonro benmonro deleted the dependabot/npm_and_yarn/testing-library/dom-7.0.2 branch March 13, 2020 14:42
@benmonro
Copy link
Member

🎉 This PR is included in version 1.11.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@kentcdodds
Copy link
Member

This probably should've been a major version bump 😬

@kentcdodds
Copy link
Member

My personal recommendation: downgrade @testing-library/dom and release a 1.11.2, then upgrade again with BREAKING CHANGE to get a 2.0.0

@benmonro
Copy link
Member

dang it, i pluralized "BREAKING CHANGES". sorry. will do

@benmonro
Copy link
Member

@dependabot reopen

@benmonro
Copy link
Member

@dependabot recreate

@dependabot-preview
Copy link
Contributor Author

Looks like this PR has already been merged. If you've moved back to an older version of @testing-library/dom a new PR will be created next time Dependabot checks your dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants