test: add onMount test and replace onDestory test #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcous
force-pushed
the
test-onmount
branch
2 times, most recently
from
605d9eb
to
1c91caf
Compare
yanick
reviewed
Jan 30, 2024
|
🎉 This PR is included in version 4.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds an
onMounttest and simplifies theonDestroytest. Supersedes #254Change log
Mounter.sveltefixture with function prop hookups toonMountandonDestroy, letting us test via spies rather than the misdirection of renderingStopwatch.sveltesince it was a little confusing and didn't directly help the tests (see above point about misdirection)consoleobject without cleanupconsole.warn) that no longer exist