Use of queryByXXX vs getByXXX

[simoncollins]

If you want to assert that an element exists and you have a page that loads slowly, you have to use queryByXXX selector variants, otherwise you will get intermittent failures using getByXXX when the element is not available in time.

I burnt a fair bit of time trying to figure out why I was getting intermittent failures because
I'm new to using testing-library and had forgotten that difference. I didn't initially make the connection that the error message I was seeing from getByText was because it was throwing an exception and not allowing Testcafe to retry the selector until the element was available.

Is it worth adding an example and/or notes about this usage distinction to the documentation? Currently they only show the usage of getByXXX selectors.

[benmonro]

@simoncollins thank you for submitting this. I will definitely add a note about this to the docs as well as a link to the cheat sheet that breaks down when to use what query.

[simoncollins]

Great, thanks @benmonro ... much appreciated, and thanks for the library!

[benmonro]

Sure! Oh by the way would you mind sharing the error message you were seeing?

On Mon, Oct 28, 2019 at 10:45 PM Simon Collins ***@***.***> wrote: Great, thanks @benmonro <https://github.com/benmonro> ... much appreciated, and thanks for the library! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#53?email_source=notifications&email_token=AADBPBDCYXKU5UKXZZ5H3CTQQ7EXBA5CNFSM4JGDUFU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECPJ5SI#issuecomment-547266249>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADBPBCFSBXEPWKXPK5S7BDQQ7EXBANCNFSM4JGDUFUQ> .

-- Ben Monro Software Developer

[simoncollins]

Sure, it was:

1) An error occurred in Selector code:

          Error: Unable to find an element with the text: Forgot your password?. This could be because the text is broken up
      by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more
      flexible.

Basically the app is quite sluggish to load at the moment and has a loading indicator before showing a login form with a link with the text Forgot your password? under it which I was using to detect that the form was shown successfully. So you intermittently get the message above followed by a dump of the DOM.

[benmonro]

thanks @simoncollins. added notes in testing-library/testing-library-docs#313