-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use getSuggestedQuery
from @testing-library/dom
#134
Comments
getSuggestedQuery
from @testing-library/dom
getSuggestedQuery
from @testing-library/dom
I'll fix it :) to do this I think we need to call makeSuggestion function of @testing-library/dom but it is not exported. Do you had another idea? @smeijer |
Wait for this one: testing-library/dom-testing-library#627 😇 |
Well, you didn't need to wait long. 😁🎉 |
Hahahaha ok. I'll update the library and fix the code |
Do you have any idea how to solve problem with |
I think we shouldn't be taking it from the iframe. Instead, we can create an in memory div, and simulate the environment there. The element can be selected with the cssPath. (from my phone) const view = document.createElement('div');
view.innerHTML = markup;
const target = view.querySelector(el.cssPath.toString());
const query = getSuggestedQuery(target, 'get', ... |
#113 already implemented this partially. But I noticed that it isn't applied yet in the
ResultSuggestions
component (the blue buttons on the bottom left)The text was updated successfully, but these errors were encountered: