feat(event): support beforeinput
#851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 818a465:
|
ph-fritsche
force-pushed
the
feat-beforeinput
branch
from
f9326dc
to
3820621
Compare
Codecov Report
@@ Coverage Diff @@
## beta #851 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 89 82 -7
Lines 1763 1718 -45
Branches 623 614 -9
=========================================
- Hits 1763 1718 -45
Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 14.0.0-beta.11 🎉 The release is available on: Your semantic-release bot 📦🚀 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Move key event behavior from
src/keyboard/pluginstosrc/event/behavior.Dispatch
beforeinputevents, so that the event handlers can cancel changes to the DOM.Fix missing
clickevents when pressing[Enter]in a form that has at least one submit button.Why:
Hopefully the new code will be easier to understand and maintain.
beforeinputevents were missing and therefore event handlers for them had no effect.When
[Enter]is pressed on an<input>element inside a form and there is at least one submit button, that button receives aclickevent.How:
Refactor all implementations for modifying the DOM into one central
input()util function.Refactor all default behavior for key events into
src/event.Drive-by fix of the
keypressimplementation for[Enter].Checklist: