New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/allow selecting options in optgroups #196
Fix/allow selecting options in optgroups #196
Conversation
Codecov Report
@@ Coverage Diff @@
## master #196 +/- ##
==========================================
+ Coverage 97.1% 97.14% +0.04%
==========================================
Files 1 1
Lines 138 140 +2
Branches 34 34
==========================================
+ Hits 134 136 +2
Misses 4 4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me. Thank you!
@all-contributors please add @jordyvandomselaar for code and tests |
I've put up a pull request to add @jordyvandomselaar! 🎉 |
🎉 This PR is included in version 8.0.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
I'm opening this PR to solve an issue where selectOptions does not work if the options are nested inside optgroup elements. I think querySelectorAll would solve this and possibly other cases where nesting could be an issue.