fix(tab): Keep focus on the document if there are no enabled, focusable elements #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanismaking
changed the title
Codecov Report
@@ Coverage Diff @@
## master #238 +/- ##
==========================================
+ Coverage 98.61% 98.63% +0.02%
==========================================
Files 1 1
Lines 144 147 +3
Branches 41 42 +1
==========================================
+ Hits 142 145 +3
Misses 2 2
Continue to review full report at Codecov.
|
|
@kentcdodds @Gpx can we get this merged? |
benmonro
approved these changes
Mar 27, 2020
|
馃帀 This PR is included in version 10.0.1 馃帀 The release is available on: Your semantic-release bot 馃摝馃殌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @Gpx and @kentcdodds. 馃憢
I ran into an issue where
tab()blows up if the case under test has not rendered any elements which are focusable. Probably a bit of a corner case, but it would be nice to have it covered.Hope the change is okay. This is my first open-source contribution! 馃槄