Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @testing-library/dom to installation #337

Merged
merged 1 commit into from Jun 10, 2020
Merged

Conversation

nickmccurdy
Copy link
Member

@nickmccurdy nickmccurdy commented Jun 10, 2020

What: Add @testing-library/dom to installation (fixes #335)

Why: This is required as a peer dependency, which wasn't obvious from the readme.

How: Readme edit

Checklist:

  • Documentation
  • Tests N/A
  • Typings N/A
  • Ready to be merged

This is required as a peer dependency, which wasn't obvious from the readme.
@codecov
Copy link

codecov bot commented Jun 10, 2020

Codecov Report

Merging #337 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #337   +/-   ##
=======================================
  Coverage   99.39%   99.39%           
=======================================
  Files           2        2           
  Lines         331      331           
  Branches       84       84           
=======================================
  Hits          329      329           
  Misses          2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4678d9...60009e2. Read the comment docs.

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kentcdodds kentcdodds merged commit 4356cc5 into master Jun 10, 2020
@kentcdodds kentcdodds deleted the nickmccurdy-patch-1 branch June 10, 2020 19:14
@kentcdodds
Copy link
Member

🎉 This PR is included in version 11.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

testing-library/user-event has unmet peer dependency testing-library
2 participants