Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix istanbul ignore #706

Merged
merged 2 commits into from
Jul 20, 2021
Merged

test: fix istanbul ignore #706

merged 2 commits into from
Jul 20, 2021

Conversation

ph-fritsche
Copy link
Member

@ph-fritsche ph-fritsche commented Jul 20, 2021

What:
Fix istanbul ignore.

Why:
Previously the ignore else had to be writting before else if to ignore the consecutive else.
Istanbul now seems to expect it right before the if.

How:
Committed with --no-verify as the pre-commit hook lint-fixed the change 🤷

Checklist:

  • [N/A] Documentation
  • Tests
  • Ready to be merged

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 20, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b444259:

Sandbox Source
userEvent-PR-template Configuration

@codecov
Copy link

codecov bot commented Jul 20, 2021

Codecov Report

Merging #706 (75bbf9c) into main (edb4d7a) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 75bbf9c differs from pull request most recent head b444259. Consider uploading reports for the commit b444259 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##              main      #706   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           50        50           
  Lines          934       935    +1     
  Branches       368       369    +1     
=========================================
+ Hits           934       935    +1     
Impacted Files Coverage Δ
src/keyboard/shared/fireInputEvent.ts 100.00% <100.00%> (ø)
src/keyboard/getEventProps.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 276d751...b444259. Read the comment docs.

@ph-fritsche ph-fritsche merged commit 1fd14e7 into main Jul 20, 2021
@ph-fritsche ph-fritsche deleted the fix-coverage branch July 20, 2021 19:04
@nickmccurdy
Copy link
Member

Thanks for figuring this out. I guess this was a bug or breaking change in an Istanbul update, do you think it's worth reporting?

@ph-fritsche
Copy link
Member Author

ph-fritsche commented Jul 21, 2021

For istanbul, I don't think so. There has been no activity on istanbuljs/istanbuljs recently.

But I'll report on kcd-script that the lintfix on pre-commit hook changes this to the wrong position.

I think the change happened with the updated dependencies in kcd-scripts@v11.2

@github-actions
Copy link

🎉 This PR is included in version 13.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants