Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: export package as bundled ESM #816

Merged
merged 2 commits into from Dec 30, 2021
Merged

fix!: export package as bundled ESM #816

merged 2 commits into from Dec 30, 2021

Conversation

ph-fritsche
Copy link
Member

@ph-fritsche ph-fritsche commented Dec 29, 2021

What:

Export package as bundled ESM

Why:

Closes #813
Closes #757

How:

The package is supposed to be consumed per default export.

Switch to an ESM export because CJS has no default export.

Bundle package because the semantically correct import paths in TS might not translate to universally correct import paths in ESM.

Checklist:

  • Ready to be merged

@ph-fritsche ph-fritsche added this to the userEvent v14 milestone Dec 29, 2021
@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 29, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit cb6ed16:

Sandbox Source
userEvent-PR-template Configuration

@codecov
Copy link

codecov bot commented Dec 29, 2021

Codecov Report

Merging #816 (cb6ed16) into beta (e9635f6) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              beta      #816   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           79        79           
  Lines         1578      1578           
  Branches       559       559           
=========================================
  Hits          1578      1578           
Impacted Files Coverage Δ
src/utils/misc/hasPointerEvents.ts 100.00% <ø> (ø)
src/utils/misc/isVisible.ts 100.00% <ø> (ø)
src/utils/pointer/firePointerEvents.ts 100.00% <ø> (ø)
src/utils/dataTransfer/Clipboard.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9635f6...cb6ed16. Read the comment docs.

@ph-fritsche ph-fritsche merged commit 6a4f005 into beta Dec 30, 2021
@ph-fritsche ph-fritsche deleted the build branch December 30, 2021 07:31
ph-fritsche added a commit that referenced this pull request Dec 30, 2021
ph-fritsche added a commit that referenced this pull request Dec 30, 2021
@ph-fritsche
Copy link
Member Author

Merged with fixed commit message in 1a5e2a7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nested default exports with using dynamic import TypeError: userEvent.click is not a function
1 participant