Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: correct false-negative for advancing timers #948

Merged
merged 1 commit into from
May 10, 2022
Merged

Conversation

ph-fritsche
Copy link
Member

What:

Rewrite test.

Why:

Previous test would not fail if advanceTimers wasn't applied.

test('advances timers when set', async () => {
jest.useFakeTimers()
jest.setTimeout(50)
// If this wasn't advancing fake timers, we'd timeout and fail the test
await wait(10000, jest.advanceTimersByTime)
jest.useRealTimers()
})

validate script doesn't typecheck tests 😞
We need to fix that.

Checklist:

  • Tests
  • Ready to be merged

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 9, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7fb4763:

Sandbox Source
userEvent-dom Configuration
userEvent-react Configuration

@codecov
Copy link

codecov bot commented May 9, 2022

Codecov Report

Merging #948 (7fb4763) into main (ee062e7) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #948   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           85        85           
  Lines         1784      1784           
  Branches       641       658   +17     
=========================================
  Hits          1784      1784           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee062e7...7fb4763. Read the comment docs.

@ph-fritsche ph-fritsche merged commit bf00145 into main May 10, 2022
@ph-fritsche ph-fritsche deleted the fix-test branch May 10, 2022 08:38
@github-actions
Copy link

🎉 This PR is included in version 14.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant