Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(keyboard): change radio group per arrow keys #995

Merged
merged 1 commit into from
Jul 19, 2022
Merged

Conversation

ph-fritsche
Copy link
Member

What:

Check next/previous radio button in group per arrow keys.

Why:

Closes #843

How:

Add default behavior for keydown.

Checklist:

  • Tests
  • Ready to be merged

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e1fa521:

Sandbox Source
userEvent-dom Configuration
userEvent-react Configuration

@codecov
Copy link

codecov bot commented Jul 19, 2022

Codecov Report

Merging #995 (e1fa521) into main (73e4347) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #995   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           86        87    +1     
  Lines         1849      1876   +27     
  Branches       686       697   +11     
=========================================
+ Hits          1849      1876   +27     
Impacted Files Coverage Δ
src/event/behavior/keydown.ts 100.00% <100.00%> (ø)
src/utils/edit/walkRadio.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73e4347...e1fa521. Read the comment docs.

@ph-fritsche ph-fritsche merged commit e1c22af into main Jul 19, 2022
@ph-fritsche ph-fritsche deleted the iss-843 branch July 19, 2022 13:48
@github-actions
Copy link

🎉 This PR is included in version 14.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keyboard arrows navigation not causing input[type=radio] to change focus
1 participant