Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support all mount options in vue-test-utils #13

Merged
merged 3 commits into from
Dec 27, 2018
Merged

Support all mount options in vue-test-utils #13

merged 3 commits into from
Dec 27, 2018

Conversation

dfcook
Copy link
Collaborator

@dfcook dfcook commented Dec 27, 2018

Allow all supported options to be passed to vue-test-utils mount function. Replaces #12 , hence including test from that PR in here.

@coveralls
Copy link

coveralls commented Dec 27, 2018

Pull Request Test Coverage Report for Build 76

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.5%) to 95.455%

Totals Coverage Status
Change from base Build 70: 0.5%
Covered Lines: 44
Relevant Lines: 45

💛 - Coveralls

Copy link
Contributor

@tim-maguire tim-maguire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this makes loads of sense to me. Much better.

Further down the line, there's probably a decent argument for deprecating the props key..?

@dfcook
Copy link
Collaborator Author

dfcook commented Dec 27, 2018

There is, should we bite the bullet and do it here making it a breaking change?

@dfcook
Copy link
Collaborator Author

dfcook commented Dec 27, 2018

Pushed a further commit that will allow props or propsData to be passed and will copy props to propsData, this will keep backwards compatibility and allow propsData to be used going forward.

@tim-maguire
Copy link
Contributor

Yeah, this seems like a sensible approach.

@dfcook dfcook merged commit e7cb193 into master Dec 27, 2018
@dfcook dfcook deleted the mount-options branch December 27, 2018 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants