Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error while restoring backed up project #41

Closed
shubhendumadhukar opened this issue May 17, 2021 · 1 comment · Fixed by #42
Closed

Error while restoring backed up project #41

shubhendumadhukar opened this issue May 17, 2021 · 1 comment · Fixed by #42
Assignees
Labels
bug Something isn't working released

Comments

@shubhendumadhukar
Copy link
Contributor

Describe the bug
While restoring a backup, camouflage throws an error for the directories not present. This might be due to missing exception handling.

To Reproduce
Steps to reproduce the behavior:
3. Error Stack Trace

internal/validators.js:124
    throw new ERR_INVALID_ARG_TYPE(name, 'string', value);
    ^

TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received undefined
    at validateString (internal/validators.js:124:11)
    at Object.resolve (path.js:980:7)
    at Object.<anonymous> (/usr/local/lib/node_modules/camouflage-server/bin/camouflage.js:116:82)
    at Module._compile (internal/modules/cjs/loader.js:1063:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1092:10)
    at Module.load (internal/modules/cjs/loader.js:928:32)
    at Function.Module._load (internal/modules/cjs/loader.js:769:14)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:72:12)
    at internal/main/run_main_module.js:17:47 {
  code: 'ERR_INVALID_ARG_TYPE'
}

Expected behavior
For missing directories, camouflage should not throw a fatal error. Instead, restore should log an error message and proceed to next directory.

Screenshots
NA

Desktop (please complete the following information):
NA

Additional context
NA

@shubhendumadhukar shubhendumadhukar added the bug Something isn't working label May 17, 2021
@shubhendumadhukar shubhendumadhukar self-assigned this May 17, 2021
Camouflage Issue Tracker automation moved this from To do to Closed May 17, 2021
shubhendumadhukar added a commit that referenced this issue May 17, 2021
* Update changelog.yml

* Fixes: #38: Add support for remaining HTTP Verbs

* Create release.yaml

* Delete changelog.yml

* Add semantic release

* fix: semantic-release

* Fixes #41 plus some other minor changes

* Update main.yml
@github-actions
Copy link

🎉 This issue has been resolved in version 0.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
Development

Successfully merging a pull request may close this issue.

1 participant