Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward eth_getProof requests pre-bedrock #142

Conversation

jyellick
Copy link

Most of the other eth_ APIs already support detecting when the call is made for a pre-bedrock block. This change simply does the same for eth_getProof

@pcw109550 pcw109550 self-requested a review March 1, 2024 17:36
Most of the other eth_ APIs already support detecting when the call is
made for a pre-bedrock block.  This change simply does the same for
eth_getProof
@jyellick jyellick force-pushed the jyellick/forward-eth-getproof-to-historical branch from 1c4f69a to 95fe5e9 Compare March 1, 2024 21:13
@jyellick
Copy link
Author

jyellick commented Mar 1, 2024

Our fork is based on v2.57 which added a logging parameter to one of the calls, fixed -- sorry for the churn.

Copy link
Member

@pcw109550 pcw109550 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually tested and confirmed that it properly relays requests for prebedrock blocks.

@pcw109550 pcw109550 merged commit 91f5b47 into testinprod-io:op-erigon Mar 12, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants