Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only enable forkchoice changes when Optimism #145

Merged

Conversation

jyellick
Copy link

@jyellick jyellick commented Mar 8, 2024

The code currently changes the default behavior of Erigon regardless of whether it is operating in an optimism mode or not. This small change simply protected this new path by checking if the currently operating chain is Optimism before changing the forkchoice logic.

The code currently changes the default behavior of Erigon regardless of
whether it is operating in an optimism mode or not.  This small change
simply protected this new path by checking if the currently operating
chain is Optimism before changing the forkchoice logic.
@pcw109550 pcw109550 requested a review from ImTei March 11, 2024 07:06
Copy link
Member

@ImTei ImTei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! we should keep compatibility with non-op chain. Thank you for your contribution!

@ImTei ImTei merged commit 63ff31c into testinprod-io:op-erigon Mar 12, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants