Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for historical jsonrpc #151

Conversation

jyellick
Copy link

The jsonrpc functions have been modified to support historical queries before the bedrock block. But, the op-e2e tests generally do not exercise any of these historical endpoints. This suite of tests covers that gap.

@ImTei ImTei requested a review from mininny March 18, 2024 02:52
Copy link

@mininny mininny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from minor comments I think this is good to go!
Thanks for the contribution 😄

turbo/jsonrpc/eth_accounts_test.go Outdated Show resolved Hide resolved
turbo/jsonrpc/eth_receipts_test.go Outdated Show resolved Hide resolved
The jsonrpc functions have been modified to support historical queries
before the bedrock block.  But, the op-e2e tests generally do not
exercise any of these historical endpoints.  This suite of tests covers
that gap.
@jyellick jyellick force-pushed the jyellick/add-historical-jsonrpc-tests branch from cd28387 to f143856 Compare March 29, 2024 20:03
@mininny
Copy link

mininny commented Mar 31, 2024

Thank you for the contribution! 👍

@mininny mininny merged commit 0c256ed into testinprod-io:op-erigon Mar 31, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants