op-node: Span Batch Limit #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcw109550
force-pushed
the
pcw109550/span-batch-limit
branch
from
a4bd8ae
to
783cf97
Compare
ImTei
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses field size limit check of span batch addressed at ethereum-optimism#7289 (comment).
Updated spec to explicitly state
MAX_SPAN_BATCH_SIZEfor max span batch size.Span batch decoding field size check:
block_countcannot be larger thanMAX_SPAN_BATCH_SIZEblock_tx_countcannot be larger thanMAX_SPAN_BATCH_SIZEoriginBitscannot be larger thanMAX_SPAN_BATCH_SIZE * 8total_block_tx_countcannot be larger thanMAX_SPAN_BATCH_SIZEtx_datacannot be larger thanMAX_SPAN_BATCH_SIZEcontractCreationBitscannot be larger thanMAX_SPAN_BATCH_SIZE * 8yParityBitscannot be larger thanMAX_SPAN_BATCH_SIZE * 8The reason why there are multiplier
8at some check is that there are 8 bits per byte.Added tests for newly added checks.