Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why basic-tests.js doesn't have test.js suffix? #18

Closed
mikicho opened this issue Nov 7, 2020 · 3 comments · Fixed by #25
Closed

Why basic-tests.js doesn't have test.js suffix? #18

mikicho opened this issue Nov 7, 2020 · 3 comments · Fixed by #25

Comments

@mikicho
Copy link
Contributor

mikicho commented Nov 7, 2020 •
edited

@goldbergyoni
I'm talking about this file: example-application/test/basic-tests.js
By mistake?
@goldbergyoni
Copy link
Contributor

Yes and No.

Yes - In real-world project, I'd call this order-api.test.js

No - Here, I wanted to emphasize that it contains examples of basic tests

What is the right name here?

@mikicho
Copy link
Contributor Author

mikicho commented Nov 8, 2020 •
edited

IMO, just add test suffix like: basic-tests.test.js so it will get the correct icon in the IDE :P

@goldbergyoni
Copy link
Contributor

Will do

@mikicho mikicho mentioned this issue Nov 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rename basic test file testjavascript/nodejs-integration-tests-best-practices
2 participants
@goldbergyoni @mikicho