Fix for the #78 #84
Merged
Fix for the #78 #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wakr
changed the title
|
|
||
| @SerializedName("zip_url") | ||
| private String zipUrl; //": "https://tmc.mooc.fi/staging/exercises/284.zip", | ||
| private String zipUrl; //": "https://example.com/staging/exercises/284.zip", |
There was a problem hiding this comment.
I think we could just drop these sample strings here... (no need to do it in this PR but you can if you wish so)
|
LGTM, nice work. Please rebase this on master and let us know, so that we can merge it. @ljleppan request for LGTM or comments |
|
LGTM |
wakr
force-pushed
the
replaced_urls_@tests
branch
from
9e29d32
to
e3a1416
Compare
Fixes testmycode#77 refactor strings to URI changes arrange two more imports
…on zip_url-field fix indentation fix indentation and import orders
…later as a placeholder for example Wiremock's localhost. DownloadExercisesTest also modified for this. 2/5 of .jsons now fixed. 4/5 of .jsons now mainly uses example.com which is later(dynamically) changed to 127.0.0.1 if wiremock is present while testing All .jsons and tests are now free of the "tmc.mooc.fi"-address. Also other real addresses were changed to example.com. Fixed little bug where 153 was 152. Correct amount of courses in course.json is 153 (checked with grep)
Fixes testmycode#77 refactor strings to URI changes arrange two more imports fix indentation fix indentation and import orders fixed little bug Brought back zip_url because it got lost after rebasing
wakr
force-pushed
the
replaced_urls_@tests
branch
from
b9fca1c
to
335e0a6
Compare
|
Rebased 👍 |
jamo
added a commit
that referenced
this pull request
Sep 13, 2015
For tests use url pointing to example.com instead of using prod urls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request will fix the .jsons and tests which were pointing to production URLs. All .jsons should now follow the logic
example.com/{resource}/and theexample.comacts as a placeholder for the test address. This "test address" is usually localhost:{freeport}.