Use default system encoding when reading test result JSON-file (Python3) #104
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Python 3 test runner uses
.tmc_test_results.json
to report its results, the contents of which are written in the default system encoding. The corresponding parser on the Java side expects the content to be utf-8 encoded, which causes a parsing error on Windows systems when non-ASCII characters appear in the test results.This patch solves the issue by reading the test result file using the default system encoding, which should match the one it was written in. The alternative solution of always having the Python 3 test runner write its results using the utf-8 encoding would require all exercises to be updated.
Finally, this solution could be made more robust by using an encoding detection library to find a compatible encoding, although that approach will result in false matches for some bytestrings.