Deprecated getLanguageName. Added getPluginName. #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -27,10 +27,18 @@ | |||
| public interface LanguagePlugin { | |||
|
|
|||
| /** | |||
| * Returns the name of the plug-in | |||
| * | |||
| * @return The name of the plug-in | |||
There was a problem hiding this comment.
We can drop the @returns part of the javadoc
|
LGTM, please fix the two comments |
|
Is everything fine with this commit? It decreases code coverage, because it adds a method that replaces old one. If the tests were changed to use new one it still would do that. |
| @@ -27,10 +27,16 @@ | |||
| public interface LanguagePlugin { | |||
|
|
|||
| /** | |||
| * Returns the name of the plug-in. | |||
| * | |||
|
Added one last comment. We don't get notified when you push new changes to the pr... |
|
Yeah I realised it from an irc conversation 😄 |
jamo
added a commit
that referenced
this pull request
Sep 13, 2015
Deprecated getLanguageName and added getPluginName.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #14