Improve StudentFileAwareZipper #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cxcorp
force-pushed
the
zipper-path-separators
branch
from
c04726f
to
a508667
Compare
2 similar comments
nygrenh
reviewed
Dec 27, 2016
| @@ -110,10 +111,13 @@ private void writeToZip(Path currentPath, ZipArchiveOutputStream zipStream, Path | |||
| log.trace("Writing {} to zip", currentPath); | |||
|
|
|||
| String name = projectPath.getParent().relativize(currentPath).toString(); | |||
| // zip standard says "/" is to be used as the path separator | |||
| name = FilenameUtils.separatorsToUnix(name); | |||
There was a problem hiding this comment.
In Unix-based systems it is legal to have \-characters in the filename. We don't want to accidentally interpret those as path separators. That's why I would prefer the implementation I proposed earlier.
cxcorp
force-pushed
the
zipper-path-separators
branch
3 times, most recently
from
ee75d66
to
a455afc
Compare
1 similar comment
2 similar comments
nygrenh
requested changes
Jan 3, 2017
| log.trace("Generating zip-compliant filename from Path \"{}\", isDirectory: {}", | ||
| path, isDirectory); | ||
| // zip standard says "/" is to be used as the path separator. | ||
| final char separator = '/'; |
There was a problem hiding this comment.
Can you move this out of the method and make it private static final char ZIP_SEPARATOR = '/'?
The StudentFileAwareZipper includes the provided root directory in the zip archive as a parent directory. File system roots aren't named directories, so they cannot be added as such.
1 similar comment
cxcorp
force-pushed
the
zipper-path-separators
branch
from
a455afc
to
1b2b5d2
Compare
cxcorp
changed the title
2 similar comments
cxcorp
force-pushed
the
zipper-path-separators
branch
from
10375a6
to
7998eb0
Compare
2 similar comments
nygrenh
approved these changes
Jan 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #75