fix the failing test for maps with null values

testng-team · May 25, 2023 · 4216a3d · 4216a3d
1 parent 7a4394b
commit 4216a3d
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/testng-asserts/src/main/java/org/testng/Assert.java b/testng-asserts/src/main/java/org/testng/Assert.java
@@ -2109,11 +2109,14 @@ private static String getNotEqualReason(Map<?, ?> actual, Map<?, ?> expected) {
       Object key = entry.getKey();
       Object value = entry.getValue();
       Object expectedValue = expected.get(key);
-      String assertMessage =
-          "Maps do not match for key:" + key + " actual:" + value + " expected:" + expectedValue;
       if (!areEqualImpl(value, expectedValue)) {
+        String assertMessage =
+            "Maps do not match for key:" + key + " actual:" + value + " expected:" + expectedValue;
         return assertMessage;
       }
+      if (value == null && !expected.containsKey(key)) {
+        return "Maps do not match for key:" + key + " actual: null but not present in expected";
+      }
     }
     return null;
   }