Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #689: <groups> at <suite> level not applied to <suite-files> #937

Merged
merged 2 commits into from Jul 18, 2016

Conversation

juherr
Copy link
Member

@juherr juherr commented Dec 31, 2015

No description provided.

@juherr
Copy link
Member Author

juherr commented Dec 31, 2015

Strange, the same test is failing on my travis too, but on jdk8: https://travis-ci.org/juherr/testng/builds/99540230
And of course, it is working well on my computer x)

@cbeust
Copy link
Collaborator

cbeust commented Dec 31, 2015

It's not merging cleanly, can you rebase it?

@juherr
Copy link
Member Author

juherr commented Dec 31, 2015

Please check #935 first

@cbeust
Copy link
Collaborator

cbeust commented Jan 2, 2016

#935 is merged.

@tique
Copy link

tique commented Feb 9, 2016

Hi,
Was the fix applied to any build?
I am still having this issue using v6.9.10
Groups at suite level not applied to suite-files.
Thanks

@juherr
Copy link
Member Author

juherr commented Feb 9, 2016

@tique Not yet. I have to rework the pul-request because juherr@6f17c4b is not working as expected and has random failures (I'm not able to reproduce the travis's problem).
It will be closed before the next release but no date for the moment.

@jitindoriya
Copy link

@juherr any update on this issue.

@juherr
Copy link
Member Author

juherr commented Jun 2, 2016

@jitindoriya Not yet, sorry. Thank for the remember :)

@juherr
Copy link
Member Author

juherr commented Jul 14, 2016

Do not merge if travis is failing

@juherr
Copy link
Member Author

juherr commented Jul 17, 2016

LGTM

@cbeust cbeust merged commit 59d4fbc into testng-team:master Jul 18, 2016
@juherr juherr deleted the issue-#689 branch July 18, 2016 04:31
@jitindoriya
Copy link

@juherr is the issue fixed, and which version is able for this fix?

@juherr
Copy link
Member Author

juherr commented Jul 18, 2016

@jitindoriya It is supposed to be fixed now and will be available in the next release (or in the current SNAPSHOT).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants