fix: Display product by order ID product list view #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Karthik-0
requested changes
Dec 7, 2022
| @@ -122,7 +122,8 @@ private static Entity addPrice(Schema schema) { | |||
|
|
|||
| private static Entity addProduct(Schema schema) { | |||
| Entity product = schema.addEntity("Product"); | |||
| product.addLongProperty("id").primaryKey(); | |||
| product.addLongProperty("order").primaryKey(); | |||
There was a problem hiding this comment.
Should not be added as primary key
Karthik-0
reviewed
Dec 9, 2022
| @@ -107,9 +109,9 @@ public void onLoadFinished(Loader<List<Product>> loader, List<Product> products) | |||
| getLoaderManager().destroyLoader(loader.getId()); | |||
|
|
|||
| } else { | |||
| deleteAndInsertProductsInDB(products); | |||
PruthiviRaj27
force-pushed
the
productByOrder
branch
from
3f922bc
to
8a2d900
Compare
Karthik-0
approved these changes
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes done
Reason for the changes
Fixes #.