Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 16:9 aspect ratio in Store detail UI #458

Merged
merged 5 commits into from
Dec 13, 2022
Merged

fix: 16:9 aspect ratio in Store detail UI #458

merged 5 commits into from
Dec 13, 2022

Conversation

PruthiviRaj27
Copy link
Contributor

@PruthiviRaj27 PruthiviRaj27 commented Dec 9, 2022 •
edited
Loading

Changes done

  • Added constrain layout around image View
  • Set image size to 16:9 ratio

Reason for the changes

  • Showing same image aspect ratio in web and mobile

Fixes # .

@Karthik-0 Karthik-0 merged commit be338ee into master Dec 13, 2022
@delete-merged-branch delete-merged-branch bot deleted the productDetailImageRatio branch December 13, 2022 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Karthik-0 Karthik-0 Karthik-0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@PruthiviRaj27 @Karthik-0