Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Rank should not be displayed until its published #507

Merged
merged 3 commits into from
Apr 25, 2023
Merged

fix: Rank should not be displayed until its published #507

merged 3 commits into from
Apr 25, 2023

Conversation

PruthiviRaj27
Copy link
Contributor

@PruthiviRaj27 PruthiviRaj27 commented Apr 18, 2023 •
edited
Loading

  • Earlier, we used to verify the rank layout based on the enableRanks field in the exam model, and if the rank was not published, it would display as "NA".
  • Currently, the rank will only be displayed in the attempt model when the rankEnabled field is set to true; otherwise, it will not be displayed.

@PruthiviRaj27 PruthiviRaj27 force-pushed the fix_rank_display branch 2 times, most recently from d99d0c3 to 30710c9 Compare April 24, 2023 06:12
@bharathwaaj bharathwaaj merged commit 6b3f555 into master Apr 25, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix_rank_display branch April 25, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathwaaj bharathwaaj bharathwaaj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@PruthiviRaj27 @bharathwaaj