This repository has been archived by the owner on Apr 3, 2023. It is now read-only.
Support Selenium 4 #164
Open
Support Selenium 4 #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dencies. Signed-off-by: ori-d <ori.dafna@testproject.io>
Signed-off-by: ori-d <ori.dafna@testproject.io>
Signed-off-by: ori-d <ori.dafna@testproject.io>
Signed-off-by: ori-d <ori.dafna@testproject.io>
… upgrade Signed-off-by: ori-d <ori.dafna@testproject.io>
Signed-off-by: ori-d <ori.dafna@testproject.io>
Signed-off-by: ori-d <ori.dafna@testproject.io>
Signed-off-by: ori-d <ori.dafna@testproject.io>
oriddd
force-pushed
the
tasks/TP-16635
branch
from
c4ef3ac
to
a6866b5
Compare
Signed-off-by: ori-d <ori.dafna@testproject.io>
s-glatshtein
suggested changes
Jan 5, 2022
| @@ -86,7 +86,7 @@ private static boolean isRedactRequired(final ReportingCommandsExecutor executor | |||
| // Check if element is a mobile password element | |||
| if (platformName.equalsIgnoreCase(Platform.ANDROID.name())) { | |||
| // Making sure it's not Mobile Web | |||
| if (StringUtils.isEmpty(capabilities.getCapability(CapabilityType.BROWSER_NAME))) { | |||
| if (StringUtils.isEmpty(capabilities.getCapability(CapabilityType.BROWSER_NAME).toString())) { | |||
There was a problem hiding this comment.
What if the capability isn't set?
| @@ -160,7 +160,7 @@ default void reportCommand(final Command command, final Response response) { | |||
| } | |||
|
|
|||
| // Check if executed from a FluentWait loop | |||
| boolean isFluentWait = traces.stream().anyMatch(t -> t.getClassName().equals(FluentWait.class.getName())); | |||
| boolean isFluentWait = traces.stream().anyMatch(t -> t.getClassName().equals(AppiumFluentWait.class.getName())); | |||
There was a problem hiding this comment.
Doesn't selenium have fluent wait anymore? What happened to it?
| /** | ||
| * | ||
| */ | ||
| public static final String APPIUM_CAPABILITY_PREFIX = "appium:"; |
There was a problem hiding this comment.
Missing documentation with explanation why this is needed
| * @throws AgentConnectException if Agent is not responding or responds with an error | ||
| * @throws InvalidTokenException if the token provided is invalid | ||
| * @throws MalformedURLException if the Agent API base URL provided is malformed | ||
| * @throws ObsoleteVersionException if the SDK version is incompatible with the Agent | ||
| */ | ||
| public AndroidDriver(final Capabilities capabilities) | ||
| public AndroidDriver(final MutableCapabilities capabilities) |
There was a problem hiding this comment.
Should this use MobileOptions, same as the new standard?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding logic to support Selenium 4 due to issue #167