Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added github actions CI #44

Merged

Conversation

yutachaos
Copy link
Contributor

@yutachaos yutachaos commented Apr 9, 2021

Description

  • Add CI using github actions

@yutachaos yutachaos force-pushed the feature/added_github_action branch from c593ff7 to 66780e5 Compare April 9, 2021 01:03
@fidian
Copy link
Contributor

fidian commented Apr 9, 2021

This uses Go? There's a comment indicating it does. Can you tell me more about it?

@yutachaos yutachaos force-pushed the feature/added_github_action branch from 849b891 to 9cb16c1 Compare April 9, 2021 23:15
@yutachaos
Copy link
Contributor Author

yutachaos commented Apr 9, 2021

This uses Go? There's a comment indicating it does. Can you tell me more about it?

Sorry.
I just forgot to modify the code that I copied and pasted, and I don't use Go.
Fixed comment.

@fidian
Copy link
Contributor

fidian commented Apr 17, 2021

I hesitate to include a package-lock.json file in this repository because it is not a Node.JS project. I only use those packages for testing. When there is a package-lock.json file, dependabot will scan the repo and look for vulnerabilities and audit the packages, then I will get far more pull requests on something that isn't strictly necessary.

I am unsure, but it might be a good idea for me to switch from package.json for testing and instead use a container or some shell code to run a script like what I have below. What do you think? Note: I am not asking you to do more work. I would do the following right after merging your code in order to eliminate package-lock.json.

#!/usr/bin/env bash
# Create a package.json so the dependency package is installed in the local directory
echo '{"private":true, "dependencies":{"async": "*"}}' > package.json
npm install
if [[ ! -d spec ]]; then
    git clone https://github.com/mustache/spec.git spec
else
    (
        cd spec;
        git pull
    )
fi
node run-spec.js spec/specs/*.json

@yutachaos
Copy link
Contributor Author

I see.
Deleted package-lock.json.

@fidian fidian merged commit dae1c66 into tests-always-included:master Nov 25, 2021
@fidian
Copy link
Contributor

fidian commented Nov 25, 2021

I merged your code but changed the commands to run the two in the repository. Thank you very much for your contribution and I am sorry it took me so long to get to this.

@yutachaos yutachaos deleted the feature/added_github_action branch April 10, 2022 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants