Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release build impossible due to using Text.propTypes.style #125

Closed
EyMaddis opened this issue Mar 28, 2018 · 0 comments · Fixed by #126
Closed

Release build impossible due to using Text.propTypes.style #125

EyMaddis opened this issue Mar 28, 2018 · 0 comments · Fixed by #126
Labels
android bug ios
Projects
react-native-dropdownalert

Comments

@EyMaddis
Copy link
Contributor

Short Description

All propTypes.style are removed at the build process of a React Native application. In order to be compatible you have to use ViewPropTypes.

I am not 100% sure how to solve this for Text and Image views

  • React Native version: 0.53.0
  • react-native-dropdownalert version: 3.4.0
  • Platform(s) (iOS, Android, or both?): both
EyMaddis added a commit to simpleTechs/react-native-dropdownalert that referenced this issue Mar 28, 2018
@EyMaddis
allow release builds by avoiding runtime access to propTypes
815bbb0 
fixes testshallpass#125
EyMaddis added a commit to simpleTechs/react-native-dropdownalert that referenced this issue Mar 28, 2018
@EyMaddis
allow release builds by avoiding runtime access to propTypes
388d195 
fixes testshallpass#125
@EyMaddis EyMaddis mentioned this issue Mar 28, 2018
Merged
react-native-dropdownalert automation moved this from backlog to Done Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
android bug ios
Projects
react-native-dropdownalert
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

allow release builds by avoiding runtime access to propTypes simpleTechs/react-native-dropdownalert
2 participants
@EyMaddis @testshallpass