Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS 9 wrong dropdown height #181

Closed
kirillpisarev opened this issue Feb 21, 2019 · 4 comments
Closed

iOS 9 wrong dropdown height #181

kirillpisarev opened this issue Feb 21, 2019 · 4 comments

Comments

@kirillpisarev
Copy link
Contributor

Short Description

On iOS 9 initial dropdown height is too big and it raises on each dropdown appearance.

Steps to Reproduce / Code Snippets / Usage

dropdown

Additional Information

  • React Native version: 0.58.4
  • react-native-dropdownalert version: 3.9.2
  • Platform(s) (iOS, Android, or both?): iOS
  • iOS version: 9
@kirillpisarev
Copy link
Contributor Author

Like it is said in docs: The purpose of SafeAreaView is to render content within the safe area boundaries of a device. It is currently only applicable to iOS devices with iOS version 11 or later.

So i have changed SafeAreaView to a simple View component for old versions and seems like it is working just fine now.

@testshallpass
Copy link
Owner

I am onboard with the fix. I reviewed the changes and had some feedback, please take a look. @kirillpisarev

Also, I found out SafeAreaView does not play nice with custom deltas #173

@kirillpisarev
Copy link
Contributor Author

Your changes now the part of the PR.

@testshallpass
Copy link
Owner

Merged fix in v3.11.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants