Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Omit SafeAreaView for old iOS versions #184

Merged
merged 5 commits into from
May 9, 2019
Merged

Omit SafeAreaView for old iOS versions #184

merged 5 commits into from
May 9, 2019

Conversation

kirillpisarev
Copy link
Contributor

@codecov-io
Copy link

codecov-io commented Mar 5, 2019 •
edited

Codecov Report

Merging #184 into master will decrease coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #184      +/-   ##
==========================================
- Coverage   71.12%   71.05%   -0.08%     
==========================================
  Files          11       11              
  Lines         187      190       +3     
==========================================
+ Hits          133      135       +2     
- Misses         54       55       +1
Impacted Files Coverage Δ
DropdownAlert.js 64.28% <ø> (-0.19%) ⬇️
constants.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c8cd88...1c387d1. Read the comment docs.

@testshallpass testshallpass self-requested a review March 18, 2019 02:15
testshallpass
testshallpass reviewed Mar 18, 2019
View reviewed changes
DropdownAlert.js Outdated Show resolved Hide resolved
@testshallpass testshallpass self-requested a review March 24, 2019 20:16
testshallpass
testshallpass requested changes Mar 24, 2019
View reviewed changes
Copy link
Owner

@testshallpass testshallpass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see inline comments

testshallpass
testshallpass requested changes Mar 25, 2019
View reviewed changes
Copy link
Owner

@testshallpass testshallpass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: add IS_IOS_BELOW_11 to module.exports in constants.

testshallpass
testshallpass reviewed Mar 25, 2019
View reviewed changes
DropdownAlert.js Outdated Show resolved Hide resolved
testshallpass
testshallpass requested changes Mar 25, 2019
View reviewed changes
Copy link
Owner

@testshallpass testshallpass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove unused Platform

@kirillpisarev
Copy link
Contributor Author

Could it be merged?

@testshallpass testshallpass merged commit 09298ab into testshallpass:master May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@testshallpass testshallpass testshallpass approved these changes

Assignees
No one assigned
Labels
ios task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kirillpisarev @codecov-io @testshallpass