ARG build variables: django, channels, daphne

[romer8]

• ARG build variables to support versions Django, django channels, and daphne according to user needs
• enviroment.yml and micro_environment.yml are edited in line according to the ARG build env variables

[coveralls]

coverage: 100.0%. remained the same
when pulling 2e73800 on romer8:django_versions
into 9d5c55b on tethysplatform:main.

[swainn]

Can the version part of the django be found using a regular expression? Try this to see if it works:

Suggested change

	sed -i "s/- django>=3.2,<6/- django==${DJANGO_VERSION}/" environment.yml micro_environment.yml; \
	sed -i "s/- django.+/- django==${DJANGO_VERSION}/" environment.yml micro_environment.yml; \

[romer8]

Yes, it can be actually with the code below now the sed command find - django, and it replaces it with the DJANGO_VERSION arg variable, but it also ignores anything -django- becuase there is some dependencies that contain django in the name followed by a -:
sed -i "s/\s*- django[^-].*/ - django==${DJANGO_VERSION}/" environment.yml micro_environment.yml;

[swainn]

I don't think this else is necessary is it?

[romer8]

No, it is not necessary, and it was removed

[swainn]

The else probably isn't necessary here either.

[romer8]

No, it is not necessary, and it was removed

[swainn]

Should probably have a regular expression on this too:

Suggested change

	sed -i "s/- daphne/- daphne==${DAPHNE_VERSION}/" environment.yml micro_environment.yml; \
	sed -i "s/- daphne.+/- daphne==${DAPHNE_VERSION}/" environment.yml micro_environment.yml; \

[romer8]

The following was changed to get anything after - daphne and replaced if arg build was set
sed -i "s/\s*- daphne.*/ - daphne==${DAPHNE_VERSION}/" environment.yml micro_environment.yml;

[swainn]

Should probably have a regular expression on this too:

Suggested change

	sed -i "s/- channels/- channels==${DJANGO_CHANNELS_VERSION}/" environment.yml micro_environment.yml; \
	sed -i "s/- channels.+/- channels==${DJANGO_CHANNELS_VERSION}/" environment.yml micro_environment.yml; \

[romer8]

The following was changed to get anything after - channels and replaced if arg build was set
sed -i "s/\s*- channels.*/ - channels==${DJANGO_CHANNELS_VERSION}/" environment.yml micro_environment.yml;

[swainn]

Can args be declared without a value?

[romer8]

Yes, they can be. They actually help with the if statement, if it is not defined then it will not enter the if statement