Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Merge Request Template #1059

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Add Merge Request Template #1059

merged 1 commit into from
Jun 7, 2024

Conversation

gagelarsen
Copy link
Contributor

Description

This merge request addresses the need for a merge request template.

Changes Made to Code:

  • Add merge request template

Related

  • None

Additional Notes

  • None

Quality Checks

  • New code is 100% tested
  • Code has been formated
  • Code has been linted
  • Docstrings for new methods have been added

@gagelarsen gagelarsen self-assigned this Jun 6, 2024
@coveralls
Copy link

Coverage Status

coverage: 100.0%. remained the same
when pulling b361b0c on merge_request_template
into 5dad136 on main.

@swainn swainn requested a review from sdc50 June 6, 2024 19:32
@swainn
Copy link
Member

swainn commented Jun 6, 2024

Looks good to me. I'd like to see what @sdc50 and @shawncrawley think

@shawncrawley
Copy link
Contributor

This seems to do the job in a very brief yet thorough at the same time sort of way. Looks good to me. If we find it's lacking later, we can always adjust.

@swainn swainn merged commit 8680dcf into main Jun 7, 2024
42 checks passed
@swainn swainn deleted the merge_request_template branch June 7, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants