Fix Custom JSON setting error when installing from file #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
romer8
commented
Jun 5, 2023
romer8
commented
- Installation of an app from the apps portion of the portal config file allows to have Custom JSON setting as a dict and JSON string, file path string
- Skips custom JSON setting assignment if it is not a string/dict
- 100% coverage
swainn
approved these changes
Jun 5, 2023
swainn
pushed a commit
that referenced
this pull request
Jul 31, 2023
* fix for json error of getting long path instead of file not found * possible fix to test, not uncometting yet. * deleted comments and improved one of the tests * fixed the file installation bug for json setting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.