feat: bump php to ">=7.2.5", use new language features of 7.2 #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd go with >=7.4 in version 3.2.0 and >=8.0 in 3.3.0 or even a new major version 4.0.0 and add a note in the readme for users with older PHP versions. If you can't update your PHP version, you can stick with an older version of the library, but I don't see a reason not to use new language features because of that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage stats of 3.1 show 0.x% for php 7.1
https://packagist.org/packages/tetranz/select2entity-bundle/php-stats#3.1
Should be >= 7.4 (but that would exclude 8% of users to upgrade). So i am not sure if it alreday time for this.
WDYT?
#183